Fix Load-Order Bug - #44
Merged
faceleg merged 3 commits intoFeb 28, 2013
Merged
faceleg merged 3 commits into
faceleg merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This code fixes a bug whereby some tree elements will not yet have loaded when the 'end' event is signalled.
Copy link
Copy Markdown
Collaborator
|
HI @fatlotus, it seems logical that the end event should fire only when the full tree has been scanned. I've added a unit test that is currently failing, thus proving your observation. If you'd like to update your fork & run the tests to ensure your code causes it to pass, we can look at merging your PR. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Couldn't help it, I wrote the tests. Thanks for your contribution! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys-
To be honest, I'm not sure if this is a bug or not. I've found it inconvenient behavior in my own use, so I've changed it in my local fork. Currently, when a nested directory is iterated over, the 'end' event is only called when all the root entries have loaded, meaning that it is impossible to know when all sub-entries are complete.
This patch requires that all sub-queries load before the root directory is to load. (There's a line in here, "tree.error" that I'm not sure I understand — right now the "end" event will not fire if this the case.)