FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Status.byIndex and StatusEntry by orderedlist · Pull Request #448 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Status.byIndex and StatusEntry - #448

Merged
orderedlist merged 4 commits into
masterfrom
ol-status-with-delta
Mar 2, 2015
ConversationCommits (4)ChecksFiles changed
Merged

Status.byIndex and StatusEntry#448
orderedlist merged 4 commits into
masterfrom
ol-status-with-delta

Conversation

orderedlist commented Mar 2, 2015

Copy link
Copy Markdown
Collaborator

Getting this started, but something weird is going on with the deltas.

1) StatusList gets status with deltas:
     AssertionError: "���\u000f\u0013\u0017" == "my-new-file-that-shouldnt-exist.file"
      at /Users/steve/github/nodegit/test/tests/status_list.js:46:18
      at /Users/steve/github/nodegit/node_modules/nodegit-promise/lib/core.js:64:15
      at flush (/Users/steve/github/nodegit/node_modules/nodegit-promise/node_modules/asap/asap.js:27:13)
      at process._tickCallback (node.js:419:13)

orderedlist commented Mar 2, 2015

Copy link
Copy Markdown
Collaborator Author

Ok, I'm happy with this current implementation. StatusEntries get more context than the statuses we get from Status.forEach. With the latter, we only get a status bit and a path. With the StatusEntry we get not only the status bit, but the deltas from head-to-index and index-to-workdir, including old and new file info. This makes identifying renames possible, along with lots of other stuff.

I was thinking we might want to add a convenience method like Repository.getExtendedStatuses to grab this info. Does that sound good?

johnhaley81 commented Mar 2, 2015

Copy link
Copy Markdown
Collaborator

Sound great, do it up.

On Mon, Mar 2, 2015, 7:24 AM Steve Smith notifications@github.com wrote:

Ok, I'm happy with this current implementation. StatusEntries get more
context than the statuses we get from Status.forEach. With the latter, we
only get a status bit and a path. With the StatusEntry we get not only the
status bit, but the deltas from head-to-index and index-to-workdir,
including old and new file info. This makes identifying renames possible,
along with lots of other stuff.

I was thinking we might want to add a convenience method like
Repository.getExtendedStatuses to grab this info. Does that sound good?

—
Reply to this email directly or view it on GitHub
#448 (comment).

orderedlist commented Mar 2, 2015

Copy link
Copy Markdown
Collaborator Author

Convenience method added as Repository.getStatusExt. I'll wait for a plus-one before merging.

orderedlist force-pushed the ol-status-with-delta branch from d3a9214 to 4947ecf Compare March 2, 2015 15:31

johnhaley81 commented Mar 2, 2015

Copy link
Copy Markdown
Collaborator

👍

orderedlist added a commit that referenced this pull request Mar 2, 2015
Merge pull request #448 from nodegit/ol-status-with-delta
617e74e 
Status.byIndex and StatusEntry
orderedlist merged commit 617e74e into master Mar 2, 2015
orderedlist deleted the ol-status-with-delta branch March 2, 2015 15:39
tbranyen modified the milestone: 0.3.0 Mar 2, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL