Str array converter fix - #451
Merged
mattyclarkson merged 2 commits intoMar 2, 2015
Merged
mattyclarkson merged 2 commits into
mattyclarkson merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
As the class is scoped to the for loop it is destroyed which means that the memory for the string is cleared. This disallows any strings to be correctly converted into a git_strarray.
mattyclarkson
force-pushed
the
str-array-converter-fix
branch
from
a54a1d0 to
c843627
Compare
March 2, 2015 17:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes up the conversion of string arrays. The problem is that the ConvertArray function was setting the string pointer to the internals of NanUtf8String but the class was being destroyed freeing the memory.
I also removed the need to call ConstructStrArray as that just does more string duplications (strdup) that aren't really needed.
The commits on this branch provide a clean transistion between the two methods that are more obvious that the complete branch diff.