Include missing lib files in nodegit.js template - #455
Merged
tbranyen merged 2 commits intoMar 3, 2015
Merged
tbranyen merged 2 commits into
tbranyen merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
We should probably script these inclusions, so future additions don't get missed.
Copy link
Copy Markdown
Collaborator
Author
|
There were a few classes here (Reset for example) that worked in the tests because we were directly requiring the lib file, but not when using NodeGit.Reset. |
Sorry, something went wrong.
tbranyen
force-pushed
the
ol-fix-including-lib
branch
from
b80a4b8 to
4134442
Compare
March 3, 2015 17:10
tbranyen
added a commit
that referenced
this pull request
Mar 3, 2015
Include missing lib files in nodegit.js template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should probably script these inclusions, so future additions don't get
missed.