FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Template proto functions by maxkorp · Pull Request #458 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Template proto functions - #458

Merged
maxkorp merged 6 commits into
masterfrom
template-proto-functions
Mar 3, 2015
ConversationCommits (6)ChecksFiles changed
Merged

Template proto functions#458
maxkorp merged 6 commits into
masterfrom
template-proto-functions

Conversation

maxkorp commented Mar 3, 2015

Copy link
Copy Markdown
Collaborator

This makes functions that share typenames available under the type. Eg instead of Clone.clone, you can just call Clone, or Reset instead of Reset.reset, etc.

Also disables the ability to require specific files, requiring you to load nodegit proper.

tbranyen reviewed Mar 3, 2015
View reviewed changes
Comment thread generate/templates/templates/nodegit.js Outdated

tbranyen Mar 3, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

local isn't necessary here, require does this automatically.

maxkorp Mar 3, 2015

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Gotcha. I've just been adding it everywhere in the name of consistency. I was actually having issues with files not loading thinking it wasnt grabbing htem, but they were bing swallowed by the catch on line 59

tbranyen commented Mar 3, 2015

Copy link
Copy Markdown
Member

I noticed a lot of require calls with the local normalizing, can you strip those out as well? It'll simplify the code a bit.

maxkorp commented Mar 3, 2015

Copy link
Copy Markdown
Collaborator Author

Yeah No problem. A lot of them got added in the tests during the clone fiasco

maxkorp force-pushed the template-proto-functions branch from 5f01cb0 to 740453d Compare March 3, 2015 22:30
maxkorp force-pushed the template-proto-functions branch from 740453d to 1906fea Compare March 3, 2015 23:20
maxkorp added a commit that referenced this pull request Mar 3, 2015
Merge pull request #458 from nodegit/template-proto-functions
fd2b66a 
Template proto functions
maxkorp merged commit fd2b66a into master Mar 3, 2015
maxkorp deleted the template-proto-functions branch March 3, 2015 23:43
maxkorp changed the title WIP: Template proto functions Template proto functions Mar 3, 2015
tbranyen added this to the 0.3.0 milestone Mar 4, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL