Adds support for strarray in structs - #461
Merged
orderedlist merged 2 commits intoMar 5, 2015
Merged
orderedlist merged 2 commits into
orderedlist merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Results in: NAN_SETTER(GitCheckoutOptions::SetPaths)
{
NanScope();
GitCheckoutOptions *wrapper = ObjectWrap::Unwrap<GitCheckoutOptions>(args.This());
Handle<Object> paths(value->ToObject());
NanDisposePersistent(wrapper->paths);
NanAssignPersistent(wrapper->paths, paths);
wrapper->raw->paths = * StrArrayConverter::Convert(paths->ToObject()) ;
} |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
That generated C++ looks good. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
I'd say lets add in a test to confirm this works and then merge it in. |
Sorry, something went wrong.
orderedlist
force-pushed
the
ol-strarray-in-structs
branch
from
2588580 to
907db37
Compare
March 4, 2015 17:32
Pathspecs happen a ton in options structs, we can finally checkout individual files, etc.
orderedlist
force-pushed
the
ol-strarray-in-structs
branch
from
907db37 to
5047566
Compare
March 4, 2015 18:10
Copy link
Copy Markdown
Collaborator
Author
|
Ok, test is in place. Someone sanity-check that please, and we can merge. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This looks good to me! |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@orderedlist, looks good. builds fine here. |
Sorry, something went wrong.
orderedlist
added a commit
that referenced
this pull request
Mar 5, 2015
Adds support for strarray in structs
Copy link
Copy Markdown
Collaborator
Author
|
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
👍 to that gif |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pathspecs happen a ton in options structs, we can finally checkout individual
files, etc.
I'll want some 👀 on this to make sure the C++ isn't doing anything wrong or leaking somewhere.