Don't assign enums to __proto__ - #464
Merged
orderedlist merged 1 commit intoMar 5, 2015
Merged
orderedlist merged 1 commit into
orderedlist merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Excellent catch! I was just doing some testing and realized that we're augmenting Function.prototype with that __proto__ assignment 😱 > Function.prototype.WALK_MODE
{ WALK_PRE: 0, WALK_POST: 1 } |
Sorry, something went wrong.
orderedlist
added a commit
that referenced
this pull request
Mar 5, 2015
Don't assign enums to __proto__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes callstack errors with apm. I think the proto assignment is a recent thing, maybe added by @maxkorp? Tests pass without, so not sure the reason for the addition.
What think ye?