FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Test in Node 0.12 and io.js by tbranyen · Pull Request #468 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Test in Node 0.12 and io.js - #468

Merged
johnhaley81 merged 9 commits into
masterfrom
test-node-012
Mar 11, 2015
ConversationCommits (9)ChecksFiles changed
Merged

Test in Node 0.12 and io.js#468
johnhaley81 merged 9 commits into
masterfrom
test-node-012

Conversation

tbranyen commented Mar 5, 2015

Copy link
Copy Markdown
Member

No description provided.

johnhaley81 commented Mar 5, 2015

Copy link
Copy Markdown
Collaborator

👍

johnhaley81 commented Mar 5, 2015

Copy link
Copy Markdown
Collaborator

https://travis-ci.org/nodegit/nodegit/jobs/53249611#L528

I'm going to cancel and restart this in Travis

tbranyen changed the title Test in Node 0.12 Test in Node 0.12 and io.js Mar 5, 2015

johnhaley81 commented Mar 6, 2015

Copy link
Copy Markdown
Collaborator

Interesting... it didn't queue up on Travis.

maxkorp commented Mar 6, 2015

Copy link
Copy Markdown
Collaborator

Right? o.O

maxkorp commented Mar 6, 2015

Copy link
Copy Markdown
Collaborator

W/e, just reset to the prior commit and recommitted the same changes.

tbranyen added this to the 0.3.0 milestone Mar 8, 2015
johnhaley81 modified the milestone: 0.3.0 Mar 10, 2015

johnhaley81 commented Mar 10, 2015

Copy link
Copy Markdown
Collaborator

I'm switching us over to use https://github.com/rvagg/pangyp until nodejs/node-gyp#564 is merged.

Reference: nodejs/node#433

John Haley added 2 commits March 10, 2015 15:38
Switch from node-gyp to pangyp
dd58715 
Currently there's a PR (nodejs/node-gyp#564) that's awaiting
a merge that will allow us to once again use node-gyp to compile
nodegit across all platforms. Until that is merged however we can
use pangyp as a stop-gap. After that PR is merged though we should
switch back to node-gyp.
Test latest iojs version on appveyor
c59309c

johnhaley81 commented Mar 10, 2015

Copy link
Copy Markdown
Collaborator

We might want to bump up timeouts on our CI tests since Travis has been running slow lately.

johnhaley81 commented Mar 11, 2015

Copy link
Copy Markdown
Collaborator

Pretty sure this was the issue.

johnhaley81 commented Mar 11, 2015

Copy link
Copy Markdown
Collaborator

Getting module did not self register

johnhaley81 commented Mar 11, 2015

Copy link
Copy Markdown
Collaborator

pangyp currently doesn't work in windows for iojs :(

https://github.com/rvagg/pangyp/issues/4

johnhaley81 commented Mar 11, 2015

Copy link
Copy Markdown
Collaborator

Should we just keep going on with the caveat of "Does not work in iojs for windows right now"?

tbranyen commented Mar 11, 2015

Copy link
Copy Markdown
Member Author

Yup, works well for me!

johnhaley81 added this to the 0.3.0 milestone Mar 11, 2015
johnhaley81 added a commit that referenced this pull request Mar 11, 2015
Merge pull request #468 from nodegit/test-node-012
43b0cc3 
Test in Node 0.12 and io.js
johnhaley81 merged commit 43b0cc3 into master Mar 11, 2015
johnhaley81 deleted the test-node-012 branch March 11, 2015 18:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL