Make index.addAll use status to increase performance - #475
Merged
johnhaley81 merged 5 commits intoMar 10, 2015
Merged
johnhaley81 merged 5 commits into
johnhaley81 merged 5 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
maxkorp
force-pushed
the
speedup-index-addall
branch
from
9417492 to
a8fd045
Compare
March 9, 2015 18:11
maxkorp
force-pushed
the
speedup-index-addall
branch
from
0180b9f to
5afb809
Compare
March 9, 2015 22:26
Comment thread
lib/index.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Can this just be: return paths;?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Yeah. I don't know the purpose of the Promise.resolve
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Are we ok with putting this in 0.3.0 milestone? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Works for me. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
I'm going to take out that Promise.resolve(paths) thing first. |
Sorry, something went wrong.
johnhaley81
added a commit
that referenced
this pull request
Mar 10, 2015
Make index.addAll use status to increase performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See here: libgit2/libgit2#2687
Doing this speeds things up from around 2500-3500ms for a small-medium repo to around 180-200ms. We should remove this once it's fixed in libgit2, but until then, this seems silly not to add.
This also adds pathspec.create (since we need that to actually compare pathspecs)