FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix symbolic reference handling in getReferences by thornbill · Pull Request #496 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Fix symbolic reference handling in getReferences - #496

Merged
johnhaley81 merged 1 commit into
nodegit:masterfrom
thornbill:fix-symbolic-refs
Mar 20, 2015
ConversationCommits (1)ChecksFiles changed
Merged

Fix symbolic reference handling in getReferences#496
johnhaley81 merged 1 commit into
nodegit:masterfrom
thornbill:fix-symbolic-refs

Conversation

thornbill commented Mar 19, 2015

Copy link
Copy Markdown
Contributor

I also updated the example in general.js so that it would return symbolic references as expected.

tbranyen reviewed Mar 19, 2015
View reviewed changes
Comment thread lib/repository.js Outdated

tbranyen Mar 19, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do we need a typeof check here? That's really only necessary if the variable is possibly undeclared. Simply do !callback or callback == null.

thornbill Mar 19, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Alright, I have updated to just use !callback.

tbranyen Mar 19, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Awesome, I'm being picky here as someone could pass a falsy value that isn't undefined and that would break your check.

thornbill Mar 19, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No problem! You have every right to be picky. 😉

johnhaley81 commented Mar 20, 2015

Copy link
Copy Markdown
Collaborator

👍 looks good. I'm going to merge this.

johnhaley81 added a commit that referenced this pull request Mar 20, 2015
Merge pull request #496 from billt2006/fix-symbolic-refs
e1b64ee 
Fix symbolic reference handling in getReferences
johnhaley81 merged commit e1b64ee into nodegit:master Mar 20, 2015
thornbill deleted the fix-symbolic-refs branch March 20, 2015 13:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL