Add convenience methods to status file - #524
Merged
tbranyen merged 2 commits intoApr 18, 2015
Merged
tbranyen merged 2 commits into
tbranyen merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
My only thought is that I'm not super hot on the method names. Anybody have any better ideas? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
I think the names are ok. Maybe isInWorkingTree? But that's sounding to verbose to me. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
The names make sense to me. Merging, thanks! |
Sorry, something went wrong.
tbranyen
added a commit
that referenced
this pull request
Apr 18, 2015
Add convenience methods to status file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds methods inWorkingTree and inIndex to StatusFiles. These just check it the status contains any WT_xxx status codes (or INDEX_xxx). It's very possible that a status could have both (eg if you've done a patch stage).