Attempt remove the delete keyword - #534
Merged
tbranyen merged 2 commits intoApr 20, 2015
Merged
tbranyen merged 2 commits into
tbranyen merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Do we know why this is failing? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
It was failing because normalizeOptions doesn't know to exclude remote_callbacks, I could have hardcoded it there, but I preferred to just take a shallow clone of the passed in options object as to not mutate the one passed. |
Sorry, something went wrong.
tbranyen
added a commit
that referenced
this pull request
Apr 20, 2015
Attempt remove the delete keyword
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #533