Introduced a new ConvenientLine class to wrap the lines returned from ConvenientHunk. - #541
Merged
johnhaley81 merged 1 commit intoApr 17, 2015
Merged
johnhaley81 merged 1 commit into
johnhaley81 merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… ConvenientHunk. Overrode the line content method to provide more useful results.
bleathem
force-pushed
the
convenient-line
branch
from
64d5a5b to
8c35271
Compare
April 17, 2015 19:36
Copy link
Copy Markdown
Collaborator
|
This looks great! It's a breaking API change but we already have some breaking API changes in for vNext anyways. As soon as tests pass I'll go ahead and merge unless anybody in @nodegit/owners has objections. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
That damn stash test... I don't really know why that one randomly fails. It's like the stash OID gets corrupted somehow. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
That might be fixed now after #535 is merged. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Looks like I got that stash test fixed. Going to go ahead and merge this. |
Sorry, something went wrong.
johnhaley81
added a commit
that referenced
this pull request
Apr 17, 2015
Introduced a new ConvenientLine class to wrap the lines returned from ConvenientHunk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also overrode the line content method to provide more useful results.