FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update to 0.4.0 by tbranyen · Pull Request #548 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Update to 0.4.0 - #548

Merged
tbranyen merged 7 commits into
masterfrom
update-to-0.4.0
May 7, 2015
ConversationCommits (7)ChecksFiles changed
Merged

Update to 0.4.0#548
tbranyen merged 7 commits into
masterfrom
update-to-0.4.0

Conversation

tbranyen commented Apr 20, 2015

Copy link
Copy Markdown
Member

Updated all third-party dependencies as well.

tbranyen changed the title Upgrade the package.json Update to 0.4.0 Apr 20, 2015

tbranyen commented Apr 21, 2015

Copy link
Copy Markdown
Member Author

Boom! I'm ready to publish 0.4.0, when ya'll are.

johnhaley81 commented Apr 21, 2015

Copy link
Copy Markdown
Collaborator

Do we want to get https://github.com/nodegit/nodegit/tree/blobToBuffer in?

tbranyen commented Apr 21, 2015

Copy link
Copy Markdown
Member Author

That'd be cool, I'm not in any particular rush, especially since the next steps are publishing...

johnhaley81 commented Apr 21, 2015

Copy link
Copy Markdown
Collaborator

All that needs now is a solid test. But it's working.

bleathem commented Apr 30, 2015

Copy link
Copy Markdown
Contributor

What's the status of this 0.4.0 release?

tbranyen commented May 1, 2015

Copy link
Copy Markdown
Member Author

@bleathem will probably happen tomorrow hopefully

bleathem commented May 1, 2015

Copy link
Copy Markdown
Contributor

👍 you guys rock!

tbranyen force-pushed the update-to-0.4.0 branch from 3fcbbe4 to 6d7848d Compare May 3, 2015 07:25

tbranyen commented May 3, 2015

Copy link
Copy Markdown
Member Author

For some reason Linux w/ Node 0.12 is the only one failing. No idea why, but we need this figured out before publishing.

John Haley added 2 commits May 5, 2015 16:52
Explicitly use nodegit.node when requiring native module
7baa338 
Some things that override node's `require` (e.g. jest) might break when
including nodegit since. This is a workaround until they fix that.

I made an issue at jestjs/jest#353
Downgraded nan to stop build breaking
1b7dddb 
nan ^1.8.0 breaks electron :(

tbranyen commented May 6, 2015

Copy link
Copy Markdown
Member Author

@johnhaley81 nan isn't the issue as far as I can tell. I noticed the same errors with or without it. As you can see by the previous builds, the latest version of nan works just fine in everything except for Node 0.12 in Linux.

johnhaley81 commented May 6, 2015

Copy link
Copy Markdown
Collaborator

Nan 1.8.x was doing some weird stuff with electron for sure but it does seem to fix it for CI. Something weird is going on. I did remember people on the nan repo saying that 1.8 is not backwards compatible. Are you able to build it locally with 1.8?

tbranyen commented May 6, 2015

Copy link
Copy Markdown
Member Author

No I wasn't able to build with 1.7 or 1.8. Although like you said CI appears to be fixed.

tbranyen commented May 7, 2015

Copy link
Copy Markdown
Member Author

I'll update the changelog again in a commit straight to master so that it gets updated to v0.4.0

tbranyen added a commit that referenced this pull request May 7, 2015
Merge pull request #548 from nodegit/update-to-0.4.0
297d05c 
Update to 0.4.0
tbranyen merged commit 297d05c into master May 7, 2015
tbranyen deleted the update-to-0.4.0 branch May 7, 2015 20:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL