FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix build issues with 0.4.0 by maxkorp · Pull Request #566 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Fix build issues with 0.4.0 - #566

Merged
johnhaley81 merged 2 commits into
masterfrom
rollback-libssh2
May 19, 2015
ConversationCommits (2)ChecksFiles changed
Merged

Fix build issues with 0.4.0#566
johnhaley81 merged 2 commits into
masterfrom
rollback-libssh2

Conversation

maxkorp commented May 12, 2015

Copy link
Copy Markdown
Collaborator

Fixes #565
Waiting to merge until we can get the false positives resolved

johnhaley81 changed the title Rollback libssh2 to 1.4.3 Fix build issues with 0.4.0 May 13, 2015

johnhaley81 commented May 13, 2015

Copy link
Copy Markdown
Collaborator

@maxkorp I think the false positives in CI should be a different PR. We should get this merged in ASAP IMO.

tbranyen reviewed May 13, 2015
View reviewed changes
Comment thread package.json Outdated

tbranyen May 13, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Isn't latest nan, 1.8.4? If that works, can we change this to ^1.8.4?

johnhaley81 May 13, 2015

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, np. It was downloading 1.8.4 but we should up that regardless.

johnhaley81 commented May 13, 2015

Copy link
Copy Markdown
Collaborator

Seg faults in iojs on linux :(

maxkorp commented May 14, 2015

Copy link
Copy Markdown
Collaborator Author

I'd like to get it working on iojs in linux before merging, but I'm cool waiting on the false positives thing. I can take a crack at it in a few.

johnhaley81 commented May 16, 2015

Copy link
Copy Markdown
Collaborator

I'm unable to repo the seg fault on linux. @tbranyen could you give this a try?

maxkorp commented May 18, 2015

Copy link
Copy Markdown
Collaborator Author

So apparently its an issue with iojs 2+. Any ideas/thoughts?

johnhaley81 commented May 19, 2015

Copy link
Copy Markdown
Collaborator

Only in linux, OSX looks to be good. Have you tried windows?

johnhaley81 mentioned this pull request May 19, 2015
Merged

johnhaley81 commented May 19, 2015

Copy link
Copy Markdown
Collaborator

Removed the bumping nan and supporting io.js from this PR.

johnhaley81 added a commit that referenced this pull request May 19, 2015
Merge pull request #566 from nodegit/rollback-libssh2
c20a6f6 
Fix build issues with 0.4.0
johnhaley81 merged commit c20a6f6 into master May 19, 2015
johnhaley81 deleted the rollback-libssh2 branch May 19, 2015 23:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build is broken on windows

3 participants

Back | FazBrowse Home | New Git URL