FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix Rebase issues by jdgarcia · Pull Request #568 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Fix Rebase issues - #568

Merged
tbranyen merged 14 commits into
nodegit:masterfrom
jdgarcia:fix-rebase
May 15, 2015
ConversationCommits (14)ChecksFiles changed
Merged

Fix Rebase issues#568
tbranyen merged 14 commits into
nodegit:masterfrom
jdgarcia:fix-rebase

Conversation

jdgarcia commented May 14, 2015

Copy link
Copy Markdown
Collaborator
  • annotated_commit was mistakenly named annotated in libgit2-supplement.json, and was thus not appearing in the NodeGit due to annotated being one of the removed groups. fixed the name.
  • added the git_rebase_next function to libgit2-supplment.json
  • updated descriptor.json for git_rebase_commit, git_rebase_finish, git_rebase_free, and git_rebase_init
  • fixed an issue with normalize_options.js causing errors if an instance of the Ctor was passed in
  • added Rebase convenience methods for normalizing options
  • added rebaseBranches and continueRebase convenience methods to Repository to help automate the rebase steps
  • added /tests/rebase.js for testing rebasing with and without the convenience methods

jdgarcia added 14 commits May 14, 2015 16:27

tbranyen commented May 15, 2015

Copy link
Copy Markdown
Member

Holy crap this is beautiful. Thank you!

johnhaley81 commented May 15, 2015

Copy link
Copy Markdown
Collaborator

Agreed! This rocks! Nice job @jdgarcia!

tbranyen added a commit that referenced this pull request May 15, 2015
Merge pull request #568 from jdgarcia/fix-rebase
84901cd 
Fix Rebase issues
tbranyen merged commit 84901cd into nodegit:master May 15, 2015

maxkorp commented May 15, 2015

Copy link
Copy Markdown
Collaborator

Yessssssss

jdgarcia deleted the fix-rebase branch April 21, 2016 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL