Fix path function in tree_entry (fix for issue #570) - #571
Merged
tbranyen merged 2 commits intoMay 15, 2015
Merged
tbranyen merged 2 commits into
tbranyen merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
If the entry path goes beyond the immediate children (a file in a subdir for instance) then path would return a path missing the subdir name
Comment thread
lib/tree.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Can we rename this path and change the variable later on to filePath?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks for this, one minor request! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks good, tyvm! |
Sorry, something went wrong.
tbranyen
added a commit
that referenced
this pull request
May 15, 2015
Fix path function in tree_entry (fix for issue #570)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #570
If the entry path goes beyond the immediate children (a file in a subdir for instance) then path would return a path missing the subdir name
As an example:
getEntry("test/rawcommit.js") => entry path will be returned as "rawcommit.js"