Check for existence to avoid throwing an error when there is no default signature - #577
Merged
johnhaley81 merged 3 commits intoMay 20, 2015
Merged
johnhaley81 merged 3 commits into
johnhaley81 merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks good, think you could write us a test as well? If you need help hop in the Gitter channel and we'll help ya with it :D |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
The existing test has been fixed to fail on error. I verified that the test failed without my fix and passes with it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Thanks for the PR! |
Sorry, something went wrong.
johnhaley81
added a commit
that referenced
this pull request
May 20, 2015
Check for existence to avoid throwing an error when there is no default signature
Copy link
Copy Markdown
Contributor
Author
|
Np. Thanks for the merge. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.