FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add instructions when using on Travis CI by coaxial · Pull Request #744 · nodegit/nodegit · GitHub

Repository navigation

Add instructions when using on Travis CI - #744

Closed
coaxial wants to merge 1 commit into
nodegit:masterfrom
coaxial:patch-1
Closed

coaxial wants to merge 1 commit into
nodegit:masterfrom
coaxial:patch-1

Conversation

coaxial commented Oct 8, 2015

Copy link
Copy Markdown

If one is using Travis CI to build a project that depends on nodegit, the build will fail because it can't compile.

These steps will keep this from happening and will let nodegit compile happily.

tbranyen commented Oct 8, 2015

Copy link
Copy Markdown
Member

This is useful information if the build does fail, although with latest Node 0.12 or 4.1 it should download the prebuilt binary that we publish.

coaxial commented Oct 8, 2015

Copy link
Copy Markdown
Author

It doesn't though, see the log for the latest build I did:

$ npm install 
> nodegit@0.5.0 install /home/travis/build/Coaxial/coverall/node_modules/nodegit
> node lifecycleScripts/install
[nodegit] Fetching binary from S3.
[nodegit] Failed to install prebuilt binary, building manually.
[nodegit] Regenerating and configuring code

I'm not sure why this happens but it makes builds take forever because it has to recompile every time.

maxkorp commented Oct 8, 2015

Copy link
Copy Markdown
Collaborator

Can you give us your platform (nix/osx?), arch, and node/npm versions?

coaxial commented Oct 8, 2015

Copy link
Copy Markdown
Author

Sure, this occurs on Travis CI when testing against node 0.10, 0.11 and 0.12, npm 1.4.28. I believe they are using Ubuntu 12.04 in Docker containers.

On 4.0 and 4.1 with npm 2.14, it fails with the following, no matter what I tried:

Message:
    /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.17' not found (required by /home/travis/build/Coaxial/coverall/node_modules/nodegit/build/Release/nodegit.node)
Stack:
Error: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.17' not found (required by /home/travis/build/Coaxial/coverall/node_modules/nodegit/build/Release/nodegit.node)
    at Error (native)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/home/travis/build/Coaxial/coverall/node_modules/nodegit/lib/nodegit.js:8:12)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)
    at Object.Module._extensions.(anonymous function) [as .js] (/home/travis/build/Coaxial/coverall/node_modules/gulp-istanbul/node_modules/istanbul/lib/hook.js:109:37)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/home/travis/build/Coaxial/coverall/lib/archive.js:9:269)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions.(anonymous function) [as .js] (/home/travis/build/Coaxial/coverall/node_modules/gulp-istanbul/node_modules/istanbul/lib/hook.js:107:24)

coaxial commented Oct 8, 2015

Copy link
Copy Markdown
Author

By the way, why not use bluebird's promisify and bluebird's promises rather than node-promisify?

tbranyen commented Oct 9, 2015

Copy link
Copy Markdown
Member

@coaxial someone tried to use Bluebird in the past, but it broke wayyyy too much stuff. I don't remember the specifics, but you can crawl through the history log for the revert.

We do not support 0.10 for precompiled builds, which means it will compile in those cases. Node 0.12 and Node 4.1 on Travis should not be compiling, can you verify this and/or show us where that's not the case?

Copy link
Copy Markdown
Collaborator

This might no longer be needed after #761

Copy link
Copy Markdown

We're having a similar issue. Travis fails to install the precompiled binary and eventually dies during build on v0.12.

When installing nodegit from master (npm i --save nodegit/nodegit#master), which includes @johnhaley81's #761, it still fails to install the precompiled binary but successfully builds and everything is A-OK.

Copy link
Copy Markdown
Collaborator

@contolini installing nodegit from the master branch won't download pre-built binaries since there are none published for master. We're looking to release again soon and when we do we'll have the pre-built binaries up for downloading during install.

maxkorp commented Dec 11, 2015

Copy link
Copy Markdown
Collaborator

I think we finally git rid of the glibc requirement correct? If so this can just be closed
CC @johnhaley81

Copy link
Copy Markdown
Collaborator

Yeah, we can close this one down. You don't need that anymore to build. If that changes for any reason we can open this back up. Thanks @coaxial

Copy link
Copy Markdown

@johnhaley81 this is still an issue

Copy link
Copy Markdown
Collaborator

Reopening due to #853

johnhaley81 reopened this Jan 6, 2016

Copy link
Copy Markdown
Member

I've since added instructions that are easier and don't require rebuilding the module (prebuilt works fine), so closing this.

tbranyen closed this Jan 15, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL