Codegen - #79
Conversation
Sorry, something went wrong.
…s is fully code-gen'd and all tests pass.
|
Yup failing because of the issue I mentioned before: "AssertionError: 'The .git file at '/etc/hosts' is malformed' == 'The .git file at '/private/etc/hosts' is malformed'". Should be an easy fix. I can look into it tomorrow. |
Sorry, something went wrong.
|
@nkallen that fix will still fail since /private doesn't exist in Linux or Windows. Maybe this? b/test/repo.js
index fa6bcd3..886dee0 100644
--- a/test/repo.js
+++ b/test/repo.js
@@ -11,8 +11,8 @@ exports.open = function(test){
test.expect(2);
// Test invalid repository
- git.Repo.open('/private/etc/hosts', function(error, repository) {
- test.equals(error.message, "The `.git` file at '/private/etc/hosts' is malformed");
+ git.Repo.open('../templates', function(error, repository) {
+ test.equals(error.message, "Could not find repository from '../templates'");
// Test valid repository
git.Repo.open('../.git', function(error, repository) { |
Sorry, something went wrong.
|
Do you guys have any comments? Should I just merge this into the WIP? |
Sorry, something went wrong.
|
I've forked a branch from your's in anticipation and started rewriting our installer to be cross platform with Windows. |
Sorry, something went wrong.
|
This is great! |
Sorry, something went wrong.
Codgen C++ Glue