FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix manual install by maxkorp · Pull Request #835 · nodegit/nodegit · GitHub

Repository navigation

Fix manual install - #835

Merged
maxkorp merged 4 commits into
masterfrom
fix-manual-install
Dec 16, 2015
Merged

maxkorp merged 4 commits into
masterfrom
fix-manual-install

Conversation

maxkorp commented Dec 16, 2015

Copy link
Copy Markdown
Collaborator

Fixes an issue where when manuallybuilding after a failed download, "undefined" would sneak in to the arguments for node-gyp. Also updates missing changelog entries (not including 0.5.x) and bumps to 0.6.3

maxkorp commented Dec 16, 2015

Copy link
Copy Markdown
Collaborator Author

This passed on appveyor the previous commit, and i only changed the travisyml, and travis has passed so I'm merging this. @johnhaley81 reviewed this just to be safe.

maxkorp added a commit that referenced this pull request Dec 16, 2015
maxkorp merged commit d120199 into master Dec 16, 2015
maxkorp deleted the fix-manual-install branch December 16, 2015 17:57

Copy link
Copy Markdown
Collaborator

@maxkorp you missed v0.5.0 in the CHANGELOG.md fyi

maxkorp commented Dec 17, 2015

Copy link
Copy Markdown
Collaborator Author

@johnhaley81 you missed my note about that :D

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL