FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Decrement the mutex use count after we've unlocked them. by joshaber · Pull Request #876 · nodegit/nodegit · GitHub

Repository navigation

Decrement the mutex use count after we've unlocked them. - #876

Merged
johnhaley81 merged 1 commit into
masterfrom
fix-mutex-cleanup-race
Jan 21, 2016
Merged

johnhaley81 merged 1 commit into
masterfrom
fix-mutex-cleanup-race

Conversation

Copy link
Copy Markdown
Collaborator

Maybe/hopefully fixes #869.

/cc @srajko

Copy link
Copy Markdown
Collaborator Author

This is predicated on my theory in #869 (comment) being correct. This is the simplest fix, but not as efficient as it could be. I'm not sure how much we care.

srajko commented Jan 21, 2016

Copy link
Copy Markdown
Collaborator

This looks good! I'm not too worried about efficiency at this point, but that's just me.

Copy link
Copy Markdown
Collaborator Author

I'm not too worried about efficiency at this point, but that's just me.

Yup, me neither 👍

Copy link
Copy Markdown
Collaborator

👍

johnhaley81 added a commit that referenced this pull request Jan 21, 2016
Decrement the mutex use count after we've unlocked them.
johnhaley81 merged commit 69d83c0 into master Jan 21, 2016
johnhaley81 deleted the fix-mutex-cleanup-race branch January 21, 2016 21:54

Copy link
Copy Markdown

👏

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash cleaning up mutexes

4 participants


Back | FazBrowse Home | New Git URL