FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix stageLines by joshaber · Pull Request #906 · nodegit/nodegit · GitHub

Repository navigation

Fix stageLines - #906

Merged
johnhaley81 merged 2 commits into
masterfrom
fix-stage-lines
Feb 16, 2016
Merged

johnhaley81 merged 2 commits into
masterfrom
fix-stage-lines

Conversation

Copy link
Copy Markdown
Collaborator

There were a couple funny things:

  1. Removing the index lock seems out of place for this function.
  2. We should calculate the diff after refreshing the index.

Comment thread lib/repository.js

var indexLock = repo.path().replace(".git/", "") + ".git/index.lock";

return fse.remove(indexLock)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

Copy link
Copy Markdown
Collaborator

LGTM. Gracias amigo.

johnhaley81 added a commit that referenced this pull request Feb 16, 2016
johnhaley81 merged commit 895d5e6 into master Feb 16, 2016
johnhaley81 deleted the fix-stage-lines branch February 16, 2016 22:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL