FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Don't check for \\ No newline at end of file\n if it can't exist by implausible · Pull Request #908 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Don't check for \\ No newline at end of file\n if it can't exist #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 1 commit into from
Feb 18, 2016
Conversation 3 Commits 1 Checks 0 Files changed
Merged

Don't check for \\ No newline at end of file\n if it can't exist #908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .cc  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
18 changes: 11 additions & 7 deletions generate/templates/manual/src/convenient_patch.cc
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,17 @@ PatchData *createFromRaw(git_patch *raw) {
const git_diff_line *line;
git_patch_get_line_in_hunk(&line, raw, i, j);

if (
j == 0 &&
!strcmp(
&line->content[strlen(line->content) - 29],
"\n\\ No newline at end of file\n"
)) {
EOFFlag = true;
if (j == 0) {
// calculate strlen only once for the first line of the first hunk.
int calculatedContentLength = strlen(line->content);
if (
calculatedContentLength > 29 &&
!strcmp(
&line->content[calculatedContentLength - 29],
"\n\\ No newline at end of file\n"
)) {
EOFFlag = true;
}
}

storeLine->origin = line->origin;
Expand Down
Back | FazBrowse Home | New Git URL