Fix debug build on windows - #918
johnhaley81 merged 1 commit into
Conversation
Sorry, something went wrong.
There was a linking exception that was fixed by changing the order of includes for node and v8 headers
Fix debug build on windows
| @@ -1,7 +1,7 @@ | |||
| // This is a generated file, modify: generate/templates/nodegit.cc. | |||
There was a problem hiding this comment.
?
Sorry, something went wrong.
There was a problem hiding this comment.
That's there in case somebody is looking at the generated file src/nodegit.cc and is like "why can't I commit my changes.
Sorry, something went wrong.
There was a problem hiding this comment.
Should we add a Combyne comment above it?
{%-- JavaScript comment below alerts contributors to not edit the generated source --%}
Sorry, something went wrong.
There was a problem hiding this comment.
Probably. That would at least clarify a bit. Might be nicer though if we just do that when we get the compiled output back, like
// This is a generated file, modify: {root template}. in the generateNativeCode.js
Looks like it's around lines 117/120 (probably a few others too)
Sorry, something went wrong.
|
Yeah, i wish we had a good way to point to the root template in combyne so we didnt have to include that in the not generated files. |
Sorry, something went wrong.
Sorry, something went wrong.
|
👍 |
Sorry, something went wrong.
There was a linking exception that was fixed by changing the order of includes for node and v8 headers