Fix tree.walk() and add test - #929
Merged
johnhaley81 merged 6 commits intoMar 1, 2016
Merged
johnhaley81 merged 6 commits into
johnhaley81 merged 6 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jdgarcia
force-pushed
the
tree-walk-fix
branch
from
2aa8218 to
927d1f4
Compare
February 29, 2016 22:55
jdgarcia
force-pushed
the
tree-walk-fix
branch
from
927d1f4 to
952b6b2
Compare
February 29, 2016 22:55
added 3 commits
March 1, 2016 09:57
johnhaley81
added a commit
that referenced
this pull request
Mar 1, 2016
Fix tree.walk() and add test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #928
This is the non-api breaking change.
How does anyone feel about changing walk to return a promise (with a progress callback) instead of an event emitter? (ex: tree.walk().then(entries => ...))