| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@srajko can you add a test to confirm that the callback is indeed being throttled? It could be another clone test. |
Sorry, something went wrong.
|
The changes are as follows:
See commit descriptions for a rundown. |
Sorry, something went wrong.
just refactoring, eliminating duplicated code
I originally tried doing the throttling in the baton but that ended up being a mistake. This moved the default result to the baton so the baton could use it. I don't think the change is necessary for the final version of this PR, but I still like moving things out of combyne-templated files so I kept it.
just refactoring, leverages the previously unused CallbackWrapper to set us up for bundling throttling state with the javascript callback.
default settings for progress callbacks.
| bool done; | ||
| }; | ||
|
|
||
| template<typename ResultT> |
There was a problem hiding this comment.
💯
Sorry, something went wrong.
Add throttling support for callbacks
A non-trivial number of segfaults are seeing this in production. Pulling this back for right now until a later release where we can fix them.
Revert "Merge pull request #932 from srajko/callback-throttle"
| Back | FazBrowse Home | New Git URL |
No description provided.