FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Define GIT_SSH_MEMORY_CREDENTIALS for libgit2 by alantrrs · Pull Request #949 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Define GIT_SSH_MEMORY_CREDENTIALS for libgit2 - #949

Merged
maxkorp merged 2 commits into
nodegit:masterfrom
alantrrs:fix-memory-creds
Sep 19, 2016
ConversationCommits (2)ChecksFiles changed
Merged

Define GIT_SSH_MEMORY_CREDENTIALS for libgit2#949
maxkorp merged 2 commits into
nodegit:masterfrom
alantrrs:fix-memory-creds

Conversation

alantrrs commented Mar 15, 2016

Copy link
Copy Markdown

Compile libgit2 with GIT_SSH_MEMORY_CREDENTIALS defined to allow
sshKeyMemoryNew to work.

Fixes #760

alantrrs commented Mar 15, 2016

Copy link
Copy Markdown
Author

This is just a rebase of #763 . However it seems like tests are still failing.

alantrrs commented Mar 15, 2016

Copy link
Copy Markdown
Author

Rebased again. However it looks like the version of libssh2 used here is not updated since it doesn't include libssh2_userauth_publickey_frommemory. See build

Any plans to update it?

johnhaley81 commented Mar 16, 2016

Copy link
Copy Markdown
Collaborator

We could update libssh2 in a different PR.

srajko force-pushed the master branch 2 times, most recently from a78275a to 206d27d Compare April 27, 2016 21:05

richardkazuomiller commented May 30, 2016

Copy link
Copy Markdown

Is there any status update on this and/or updating libssh2? I'd like to use sshKeyMemoryNew. I'm not good enough at C to figure out how to contribute at all though, sorry (^^ゞ

jamon commented Aug 16, 2016 •
edited
Loading

Copy link
Copy Markdown

This definitely works with libssh2 1.7.0. I'm happy to walk through the steps to get it working, below, but I'm not familiar enough with node-gyp and nodegit's build process to do it in a pull-request worthy way.

checkout the latest nodegit code and do the following (only tested on linux):

  • remove vendor/libssh2 entirely and commit this
  • cd vendor ; git clone -b tags/libssh2-1.7.0 https://github.com/libssh2/libssh2.git (this could be done as a submodule if you'd like)
  • cd libssh2 ; ./buildconf
  • cd ../.. ; npm install
  • sudo npm link -g
  • add "GIT_SSH_MEMORY_CREDENTIALS" to the "defines" array for libgit2 (part of this pull request shows this part)

use the globally installed nodegit from your projects

maxkorp commented Aug 16, 2016

Copy link
Copy Markdown
Collaborator

@jamon which OS were you testing on though? I've got a pr here: #1071

But it dies for windows

maxkorp commented Sep 15, 2016

Copy link
Copy Markdown
Collaborator

Up to date! @alantrrs care to rebase on top of master?

Define GIT_SSH_MEMORY_CREDENTIALS for libgit2
f61f52e 
Compile libgit2 with GIT_SSH_MEMORY_CREDENTIALS defined to allow
sshKeyMemoryNew to work.

Fixes nodegit#760

alantrrs commented Sep 15, 2016

Copy link
Copy Markdown
Author

rebased

maxkorp commented Sep 19, 2016

Copy link
Copy Markdown
Collaborator

Nice, TY

maxkorp merged commit ef34d8a into nodegit:master Sep 19, 2016
maxkorp mentioned this pull request Sep 19, 2016
Closed

kid commented Oct 14, 2016

Copy link
Copy Markdown

Any changes to see this in a new release soon?
I'm trying to install from master but I'm facing other issues

Thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL