FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Put the path to node-pre-gyp in quotes in install.js by ksambhi · Pull Request #951 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Put the path to node-pre-gyp in quotes in install.js #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ksambhi wants to merge 13 commits into from
Conversation 15 Commits 13 Checks 0 Files changed
Closed

Put the path to node-pre-gyp in quotes in install.js #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
680d4e3
Put the path to node-pre-gyp in quotes in install.js
ksambhi Mar 15, 2016
6be31fe
Bump nan to 2.2.0
Mar 15, 2016
e9d50fa
Use node 5.8.x on CI
Mar 15, 2016
1af2386
Fix issue where " is required
ksambhi Mar 15, 2016
1cfb51b
Skip broken http test
Mar 15, 2016
89455f4
Merge pull request #952 from nodegit/fix-node-5.8.0
johnhaley81 Mar 15, 2016
74ff595
Bump nan to 2.2.0
Mar 15, 2016
6642a76
Use node 5.8.x on CI
Mar 15, 2016
4f35617
Skip broken http test
Mar 15, 2016
30587d8
Merge branch 'fix-install-issue-username-space-windows' of https://gi…
ksambhi Mar 16, 2016
612540e
Put the path to node-pre-gyp in quotes in install.js
ksambhi Mar 15, 2016
f451b68
Fix issue where " is required
ksambhi Mar 15, 2016
4c7661d
Merge branch 'fix-install-issue-username-space-windows' of https://gi…
ksambhi Mar 16, 2016
File filter

Filter by extension

Filter by extension .js  (2) .json  (1) .yml  (2) All 3 file types selected
Only manifest files
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion .travis.yml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ env:
matrix:
- export NODE_VERSION="0.12"
- export NODE_VERSION="4.1"
- export NODE_VERSION="5.0"
- export NODE_VERSION="5.8"

matrix:
fast_finish: true
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ environment:
- nodejs_version: "0.12"
# Node.js
- nodejs_version: "4.1"
- nodejs_version: "5.0"
- nodejs_version: "5.8"

matrix:
fast_finish: true
Expand Down
2 changes: 1 addition & 1 deletion lifecycleScripts/install.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ return installPrebuilt();
function installPrebuilt() {
console.info("[nodegit] Fetching binary from S3.");
var npg = pathForTool("node-pre-gyp");
return exec(npg + " install --fallback-to-build=false")
return exec("\""+ npg + "\" install --fallback-to-build=false")
.then(
function() {
console.info("[nodegit] Completed installation successfully.");
Expand Down
2 changes: 1 addition & 1 deletion package.json
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"lcov-result-merger": "~1.0.2",
"lodash": "~3.10.1",
"mocha": "~2.3.4",
"nan": "~2.0.9",
"nan": "^2.2.0",
"node-gyp": "~3.0.3",
"nw-gyp": "~0.12.4"
},
Expand Down
2 changes: 1 addition & 1 deletion test/tests/clone.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe("Clone", function() {
});
});

it("can clone with http", function() {
it.skip("can clone with http", function() {
var test = this;
var url = "http://git.tbranyen.com/smart/site-content";

Expand Down
Back | FazBrowse Home | New Git URL