FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make Ignore.pathIsIgnored async by joshaber · Pull Request #970 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Make Ignore.pathIsIgnored async - #970

Merged
johnhaley81 merged 2 commits into
masterfrom
async-path-is-ignored
Mar 28, 2016
ConversationCommits (2)ChecksFiles changed
Merged

Make Ignore.pathIsIgnored async#970
johnhaley81 merged 2 commits into
masterfrom
async-path-is-ignored

Conversation

joshaber commented Mar 25, 2016

Copy link
Copy Markdown
Collaborator

Since it’s potentially doing IO and touching global state, it should be async.

joshaber mentioned this pull request Mar 25, 2016
Merged
2 tasks done
nathansobo reviewed Mar 25, 2016
View reviewed changes
Comment thread generate/input/descriptor.json
}
}
},
"isAsync": true

nathansobo Mar 25, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Wow it's pretty cool that this is all it took.

joshaber Mar 25, 2016

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💥 👶

nathansobo Mar 25, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Where'd this baby come from!? Now I gotta take care of it.

tbranyen Mar 25, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

        🎉                                   🎉
    🎉 yeah, it's pretty cool        🎉
       🎉                 🎉
     🎉;     🎉
🐧

johnhaley81 commented Mar 25, 2016

Copy link
Copy Markdown
Collaborator

lol

joshaber commented Mar 28, 2016

Copy link
Copy Markdown
Collaborator Author

This should be ready to merge AFAIK.

johnhaley81 commented Mar 28, 2016

Copy link
Copy Markdown
Collaborator

LGTM. Thanks @joshaber

johnhaley81 merged commit a32265c into master Mar 28, 2016
johnhaley81 deleted the async-path-is-ignored branch March 28, 2016 17:48
johnhaley81 removed the ready label Mar 28, 2016

joshaber commented Mar 28, 2016

Copy link
Copy Markdown
Collaborator Author

🙇

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL