Add support for git_repository__cleanup - #975
Merged
johnhaley81 merged 1 commit intoMar 29, 2016
Merged
johnhaley81 merged 1 commit into
johnhaley81 merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
The cleanup seems to be working nicely in conjunction with #958 - tested this in GitKraken and seeing memory usage improvements (as well as a lot more calls to git_commit__free) when changing repositories (and cleaning up the old repository when changing). The advantage of cleanup over free is that cleanup leaves the repository object functioning, and that avoids problems with instances that still have a reference to the repo - this makes safer to call explicitly for the time being, when trying to address memory usage problems (until we get automatic memory management nailed down for all types). |
Sorry, something went wrong.
srajko
force-pushed
the
repository-cleanup
branch
from
015efd7 to
ec97dbc
Compare
March 28, 2016 19:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.