FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support for setting orientation inside progressbar widget by Uriziel01 · Pull Request #39 · nodegui/nodegui · GitHub

Support for setting orientation inside progressbar widget - #39

Merged
a7ul merged 4 commits into
nodegui:masterfrom
Uriziel01:master
Aug 22, 2019
Merged

Support for setting orientation inside progressbar widget#39
a7ul merged 4 commits into
nodegui:masterfrom
Uriziel01:master

Conversation

Copy link
Copy Markdown
Contributor

It's also a first pull request to validate my workflow is in fact valid for further development.

a7ul commented Aug 22, 2019
edited
Loading

Copy link
Copy Markdown
Collaborator

Wow!
One tiny addition,
I would also add Orientation to the exports here: https://github.com/nodegui/nodegui/blob/master/src/index.ts
@Uriziel01

Copy link
Copy Markdown
Contributor Author

@master-atul Ohhh I overlooked that part, thanks for pointing it out, I've made the change 👍

a7ul commented Aug 22, 2019

Copy link
Copy Markdown
Collaborator

Merging this. Will go out in next release 🍺

a7ul merged commit 2011d51 into nodegui:master Aug 22, 2019

a7ul commented Aug 22, 2019

Copy link
Copy Markdown
Collaborator

@all-contributors please add @Uriziel01 for code

Copy link
Copy Markdown
Contributor

@master-atul

I've put up a pull request to add @Uriziel01! 🎉

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL