Encode uri to support utf8 chars - #46
Open
RobinQu wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Sorry for the delay here! We've been waiting on all the issues / pull-requests for node-cloudfiles and node-cloudservers until we released pkgcloud: a new cross-provider unified IaaS library for node.js: https://github.com/nodejitsu/pkgcloud We added a deprecation notice for this library, but would you consider reimplementing your pull-request for the Rackspace provider in pkgcloud? It would make you a HERO in my book 👍 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A filename, which is part of request URI in many APIs, is not necessary to be consisted of only English chars.
Considering support for such non-asci chars, we should encodeURI() before sending the request.
In fact, current implementation of storageUrl and cdnUrl really annoys me when uploading files with Chinese file names as the server responds no error but files are nowhere to be seen on the Cloudfile.
And the problem goes away with this fix.