FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

rules: accept revert commit titles that were elongated by git by RaisinTen · Pull Request #99 · nodejs/core-validate-commit · GitHub

/ core-validate-commit Public

rules: accept revert commit titles that were elongated by git - #99

Merged
RaisinTen merged 1 commit into
nodejs:mainfrom
RaisinTen:rules/accept-revert-commit-titles-that-were-elongated-by-git
Jul 3, 2022
ConversationCommits (1)ChecksFiles changed
Merged

rules: accept revert commit titles that were elongated by git#99
RaisinTen merged 1 commit into
nodejs:mainfrom
RaisinTen:rules/accept-revert-commit-titles-that-were-elongated-by-git

Conversation

RaisinTen commented Jun 26, 2022

Copy link
Copy Markdown
Member

This change ensures that the commit message linter doesn't reject
revert commits that originally had commit titles with an acceptable
length but were elongated during the revert process by running
git revert.

Fixes: #97
Signed-off-by: Darshan Sen raisinten@gmail.com

RaisinTen mentioned this pull request Jun 26, 2022
Closed
rules: accept revert commit titles that were elongated by git
9a6759f 
This change ensures that the commit message linter doesn't reject
revert commits that originally had commit titles with an acceptable
length but were elongated during the revert process by running
`git revert`.

Fixes: nodejs#97
Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen force-pushed the rules/accept-revert-commit-titles-that-were-elongated-by-git branch from 7d75f52 to 9a6759f Compare June 26, 2022 11:07

codecov Bot commented Jun 26, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #99 (9a6759f) into main (63c3f75) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   93.88%   93.89%   +0.01%     
==========================================
  Files          19       19              
  Lines         458      459       +1     
==========================================
+ Hits          430      431       +1     
  Misses         28       28
Impacted Files Coverage Δ
lib/rules/title-length.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c3f75...9a6759f. Read the comment docs.

tniessen approved these changes Jun 27, 2022
View reviewed changes

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If a revert is reverted, doesn't git turn that into Revert "Revert "...""? Maybe that changed or I am misremembering, but if it does, this should maybe account for that.

RaisinTen commented Jun 27, 2022

Copy link
Copy Markdown
Member Author

If a revert is reverted, doesn't git turn that into Revert "Revert "...""? Maybe that changed or I am misremembering, but if it does, this should maybe account for that.

@tniessen you're correct about the generated commit title but it seems core-validate-commit is not able to parse the subsystem correctly in that case, so I guess support for Revert "Revert "..."" commits can be added in another PR?

RaisinTen merged commit abc044e into nodejs:main Jul 3, 2022
RaisinTen deleted the rules/accept-revert-commit-titles-that-were-elongated-by-git branch July 3, 2022 08:06

RaisinTen commented Jul 3, 2022

Copy link
Copy Markdown
Member Author

@richardlau since you've been creating most of the releases for this repo recently, I thought I should ask you if you could give my npm account (https://www.npmjs.com/~raisinten) enough permissions, so that I can publish v3.16.1 with this change please? (I get this error when I run npm publish - 403 Forbidden - PUT https://registry.npmjs.org/core-validate-commit - You do not have permission to publish "core-validate-commit". Are you logged in as the correct user?)

richardlau commented Jul 4, 2022

Copy link
Copy Markdown
Member

@RaisinTen I've added you via

$ npm owner add raisinten core-validate-commit
This operation requires a one-time password.
Enter OTP: ******
npm notice INFO: User raisinten invited to package core-validate-commit successfully.
+ raisinten (core-validate-commit)

RaisinTen commented Jul 4, 2022

Copy link
Copy Markdown
Member Author

@richardlau thanks, I've published v3.16.1! :-)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

targos targos approved these changes
tniessen tniessen approved these changes
+1 more reviewer
Trott Trott approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Accept revert commit titles that are elongated by git

5 participants

Back | FazBrowse Home | New Git URL