FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Node.js 18.19.0, 21.3.0 by knksmith57 · Pull Request #2002 · nodejs/docker-node · GitHub

/ docker-node Public

feat: Node.js 18.19.0, 21.3.0 - #2002

Closed
knksmith57 wants to merge 1 commit into
nodejs:mainfrom
knksmith57:version-update
ConversationCommits (1)ChecksFiles changed
Closed

feat: Node.js 18.19.0, 21.3.0#2002
knksmith57 wants to merge 1 commit into
nodejs:mainfrom
knksmith57:version-update

Conversation

knksmith57 commented Dec 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

knksmith57 commented Dec 1, 2023

Copy link
Copy Markdown
Contributor Author

Note: it doesn't look like update.sh is correctly handling the alpine image updates due to a failing checksum fetch for 18.x

❯ ./update.sh alpine
Updating version 18...
Updating version 20...
Updating version 21...
18/bookworm/Dockerfile is already up to date!
20/bookworm/Dockerfile is already up to date!
18/bullseye-slim/Dockerfile is already up to date!
18/bullseye/Dockerfile is already up to date!
18/buster-slim/Dockerfile is already up to date!
18/buster/Dockerfile is already up to date!
18/bookworm-slim/Dockerfile is already up to date!
20/buster/Dockerfile is already up to date!
20/bullseye/Dockerfile is already up to date!
**********
Fatal Error: Failed to fetch checksum for version 18.19.0
**********
20/bookworm-slim/Dockerfile is already up to date!
**********
Fatal Error: Failed to fetch checksum for version 18.19.0
**********
20/bullseye-slim/Dockerfile is already up to date!
20/alpine3.18/Dockerfile is already up to date!
20/buster-slim/Dockerfile is already up to date!
20/alpine3.17/Dockerfile is already up to date!
21/bookworm/Dockerfile is already up to date!
21/bookworm-slim/Dockerfile is already up to date!
21/bullseye/Dockerfile is already up to date!
21/bullseye-slim/Dockerfile is already up to date!
21/alpine3.17/Dockerfile is already up to date!
21/alpine3.18/Dockerfile is already up to date!
Done!

knksmith57 commented Dec 1, 2023

Copy link
Copy Markdown
Contributor Author

Looks like the checksum file for 18.19.0 is missing on unofficial-builds.nodejs.org: https://unofficial-builds.nodejs.org/download/release/v18.19.0/SHASUMS256.txt

knksmith57 mentioned this pull request Dec 1, 2023
Closed

knksmith57 commented Dec 1, 2023

Copy link
Copy Markdown
Contributor Author

Filed nodejs/node#50997. It turns out all release artifacts for 18.19.0 for alpine are missing.

https://unofficial-builds.nodejs.org/download/release/v18.19.0/

knksmith57 commented Dec 1, 2023

Copy link
Copy Markdown
Contributor Author

@richardlau has requeued the 18.19.0 release build for us 🙏: nodejs/node#50997 (comment)

feat: Node.js 18.19.0, 21.3.0
a118a3d 
Signed-off-by: Kyle Smith <kyle@ksmith.dev>

knksmith57 commented Dec 1, 2023

Copy link
Copy Markdown
Contributor Author

OK, alpine images are updated and things look good 💯

This is ready for review 🙏

knksmith57 commented Dec 1, 2023

Copy link
Copy Markdown
Contributor Author

nvm, this is obviated by #2003

knksmith57 closed this Dec 1, 2023
knksmith57 deleted the version-update branch December 1, 2023 23:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL