FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

attempt-backport: unlabel and clean labeling by Fishrock123 · Pull Request #104 · nodejs/github-bot · GitHub

/ github-bot Public

attempt-backport: unlabel and clean labeling - #104

Merged
phillipj merged 2 commits into
nodejs:masterfrom
Fishrock123:attempt-backport-unlabel-and-clean-labeling
Jan 5, 2017
ConversationCommits (2)ChecksFiles changed
Merged

attempt-backport: unlabel and clean labeling#104
phillipj merged 2 commits into
nodejs:masterfrom
Fishrock123:attempt-backport-unlabel-and-clean-labeling

Conversation

Fishrock123 commented Dec 13, 2016

Copy link
Copy Markdown
Contributor

Should fix #100 (comment) while also giving a way to see when a PR update has changed the backportability.

This was always on the plans, I just hadn't gotten to it before.

cc @phillipj and maybe also @thealphanerd

I don't really trust myself that it'l work without testing though, but I have a plan on how to test the script, so I'm going to do that next and then rebase this ontop.

Fishrock123 requested a review from phillipj December 13, 2016 18:55

This comment was marked as off-topic.

Sign in to view

Fishrock123 force-pushed the attempt-backport-unlabel-and-clean-labeling branch 2 times, most recently from e25c998 to 9acb63e Compare December 14, 2016 15:03

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

phillipj commented Dec 16, 2016

Copy link
Copy Markdown
Member

Other than my recent negate comments, this LGTM

Fishrock123 commented Dec 22, 2016

Copy link
Copy Markdown
Contributor Author

@phillipj On second look I think my previous checks were wrong. We only want to remove it if we added it.

phillipj commented Dec 26, 2016

Copy link
Copy Markdown
Member

@Fishrock123 not sure I follow you.. If we only want the bot to remove labels it added itself previously, that still means my .includes() comments are valid?

If I understand the current code correctly, labels added by the bot will not be removed since it will prevent removeLabelFromPR() from being reached if the label in question was actually added by the bot.

Fishrock123 force-pushed the attempt-backport-unlabel-and-clean-labeling branch from 9acb63e to a13ed9a Compare January 4, 2017 20:29

Fishrock123 commented Jan 4, 2017

Copy link
Copy Markdown
Contributor Author

@phillipj You're right. I read it wrong. Updated.

Fishrock123 mentioned this pull request Jan 4, 2017
Open

This comment was marked as off-topic.

Sign in to view

phillipj merged commit 3f2099d into nodejs:master Jan 5, 2017

This comment was marked as off-topic.

Sign in to view

Fishrock123 added a commit that referenced this pull request Jan 5, 2017
attempt-backport: remove outdated comment
5688b42 
Refs: #104
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
phillipj phillipj approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

attempt-backport still does not work Edit: now working?!

2 participants

Back | FazBrowse Home | New Git URL