fix(owners): path shouldn't start with . - #275
Merged
mmarchini merged 1 commit intoAug 9, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
cc @nodejs/github-bot |
Sorry, something went wrong.
4 tasks
phillipj
reviewed
Aug 9, 2020
Comment thread
lib/node-owners.js
| const { parse } = require('codeowners-utils') | ||
| // NOTE(mmarchini): `codeowners-utils` doesn't respect ./ prefix, | ||
| // so we use micromatch | ||
| const micromatch = require('micromatch') |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This can be uninstalled now, right?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Right, forgot to uninstall before committing. Will do it before landing
Sorry, something went wrong.
phillipj
approved these changes
Aug 9, 2020
phillipj
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Other than comment about micromatch dep, this LGTM
Sorry, something went wrong.
mmarchini
force-pushed
the
fix-codeowners-path
branch
from
8b33a97 to
1999f82
Compare
August 9, 2020 21:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.