FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Status Line Complete notification by tomika · Pull Request #106 · nodejs/http-parser · GitHub

This repository was archived by the owner on Nov 6, 2022. It is now read-only.
/ http-parser Public archive

Status Line Complete notification - #106

Closed
tomika wants to merge 2 commits into
nodejs:masterfrom
tomika:master
Closed

Status Line Complete notification#106
tomika wants to merge 2 commits into
nodejs:masterfrom
tomika:master

Conversation

tomika commented Mar 24, 2012

Copy link
Copy Markdown

A new notification callback is inserted called "status complete", that is called only when a valid status line read.
This way if a parse error occured and it is in the status line the message can be treated as a valid simple response. Collecting input until "status complete" callback and switch mode on error makes possible to handle this rare special case written in RFC-1945 Section 6.

Copy link
Copy Markdown
Member

Looks non-intrusive enough. Can you add a test? And maybe point me to one or two servers that work like that? I'd like to test how other tools handle it.

tomika commented Mar 24, 2012

Copy link
Copy Markdown
Author

Hi,

I don't know exactly how a test case of a notification callback should
look like, but many servers (ie. www.apache.org and www.debian.org) send
Simple Response if you send them a Simple Request (ie. GET / ).

Best Regards,
/tomika

2012.03.24. 13:50 keltezéssel, Ben Noordhuis írta:

Looks non-intrusive enough. Can you add a test? And maybe point me to one or two servers that work like that? I'd like to test how other tools handle it.


Reply to this email directly or view it on GitHub:
#106 (comment)

Copy link
Copy Markdown
Contributor

Simple requests haven't been actively used since HTTP 0.9 and I know of nothing that sends them. Do you think this feature is valuable, @tomika? If so I'd be happy to write some tests for you.

tomika commented Dec 14, 2012

Copy link
Copy Markdown
Author

It's very kind of you.

Unfortunately in corporate environments there are some dinosaurs I have to live with. I would be glad if you would be so kind and create the required test cases and the suggested patches (I already use for while) would be merged into main branch.

Best Regards,
/tomika

Copy link
Copy Markdown
Member

Simple requests haven't been actively used since HTTP 0.9 and I know of nothing that sends them.

FWIW, I know of at least one cable modem that sends HTTP 0.9 responses.

tomika commented Dec 15, 2012

Copy link
Copy Markdown
Author

I work for telco companies and have to communicate with HUAWEII devices (among many others). What else should I say more? ;o)

This was referenced Dec 15, 2012

Copy link
Copy Markdown
Contributor

This can be closed

bnoordhuis closed this Dec 19, 2012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL