FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src,test: support node.js >= 8 by bnoordhuis · Pull Request #82 · nodejs/llnode · GitHub

/ llnode Public

src,test: support node.js >= 8 - #82

Merged
bnoordhuis merged 2 commits into
nodejs:masterfrom
bnoordhuis:n8
May 2, 2017
ConversationCommits (2)ChecksFiles changed
Merged

src,test: support node.js >= 8#82
bnoordhuis merged 2 commits into
nodejs:masterfrom
bnoordhuis:n8

Conversation

bnoordhuis commented Apr 25, 2017

Copy link
Copy Markdown
Member

This depends on changes that haven't been upstreamed yet. Diff for the eager:

diff --git a/deps/v8/tools/gen-postmortem-metadata.py b/deps/v8/tools/gen-postmortem-metadata.py
index 8857134..8f8d8a1 100644
--- a/deps/v8/tools/gen-postmortem-metadata.py
+++ b/deps/v8/tools/gen-postmortem-metadata.py
@@ -99,6 +99,22 @@ consts_misc = [
         'value': 'kAccessor' },
     { 'name': 'prop_kind_mask',
         'value': 'PropertyDetails::KindField::kMask' },
+    { 'name': 'prop_location_Descriptor',
+        'value': 'kDescriptor' },
+    { 'name': 'prop_location_Field',
+        'value': 'kField' },
+    { 'name': 'prop_location_mask',
+        'value': 'PropertyDetails::LocationField::kMask' },
+    { 'name': 'prop_location_shift',
+        'value': 'PropertyDetails::LocationField::kShift' },
+    { 'name': 'prop_attributes_NONE', 'value': 'NONE' },
+    { 'name': 'prop_attributes_READ_ONLY', 'value': 'READ_ONLY' },
+    { 'name': 'prop_attributes_DONT_ENUM', 'value': 'DONT_ENUM' },
+    { 'name': 'prop_attributes_DONT_DELETE', 'value': 'DONT_DELETE' },
+    { 'name': 'prop_attributes_mask',
+        'value': 'PropertyDetails::AttributesField::kMask' },
+    { 'name': 'prop_attributes_shift',
+        'value': 'PropertyDetails::AttributesField::kShift' },
     { 'name': 'prop_index_mask',
         'value': 'PropertyDetails::FieldIndexField::kMask' },
     { 'name': 'prop_index_shift',

Verified locally to work with node.js v4, v6, v7 and v8.0.0-pre and is clang-format clean.

This comment was marked as off-topic.

Sign in to view

hhellyer commented Apr 26, 2017

Copy link
Copy Markdown
Contributor

I'm going to have a proper look at this, I need to update my Node built tree and put your gen-postmortem-metadata.py patch in first though. (Didn't want you to think this is being ignored!)

hhellyer commented Apr 26, 2017

Copy link
Copy Markdown
Contributor

Ok, doing the updates took less time than expected. :-)
LGTM with the updated gen-postmortem-metadata.py in the build.

@indutny - Should we merge this or wait until Node 8 releases?

bnoordhuis commented May 1, 2017

Copy link
Copy Markdown
Member Author

Dropped the single-character variable names. The V8 patch landed in node.js master, see nodejs/node#12722. Barring objections, I'll merge this tomorrow.

bnoordhuis added 2 commits May 2, 2017 12:41
llscan: fix lint
8d0446a 
PR-URL: #82
Reviewed-By: Howard Hellyer <hhellyer@uk.ibm.com>
src,test: support node.js >= 8
b73e042 
Teach the object property decoder to recognize the layout of objects
in newer versions of V8.

Fixes: #81
PR-URL: #82
Refs: https://codereview.chromium.org/2842843004/
Refs: nodejs/node#12722
Reviewed-By: Howard Hellyer <hhellyer@uk.ibm.com>
bnoordhuis merged commit b73e042 into nodejs:master May 2, 2017
bnoordhuis deleted the n8 branch May 2, 2017 10:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
hhellyer hhellyer left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL