Commit 02ac8ba
test: change tmp directories prefix
`.tmp` prefix allows easier exclusion
PR-URL: #16372
Refs: #16010
Refs: #16278
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent e80d878 commit 02ac8ba
2 files changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2,7 +2,6 @@ lib/internal/v8_prof_polyfill.js | |||
| 2 | 2 | lib/punycode.js | |
| 3 | 3 | test/addons/??_* | |
| 4 | 4 | test/fixtures | |
| 5 | - test/tmp* | ||
| 6 | 5 | tools/eslint | |
| 7 | 6 | tools/icu | |
| 8 | 7 | node_modules | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,7 +38,9 @@ const noop = () => {}; | |||
| 38 | 38 | ||
| 39 | 39 | exports.fixturesDir = fixturesDir; | |
| 40 | 40 | ||
| 41 | - exports.tmpDirName = 'tmp'; | ||
| 41 | + // Using a `.` prefixed name, which is the convention for "hidden" on POSIX, | ||
| 42 | + // gets tools to ignore it by default or by simple rules, especially eslint. | ||
| 43 | + exports.tmpDirName = '.tmp'; | ||
| 42 | 44 | // PORT should match the definition in test/testpy/__init__.py. | |
| 43 | 45 | exports.PORT = +process.env.NODE_COMMON_PORT || 12346; | |
| 44 | 46 | exports.isWindows = process.platform === 'win32'; | |
0 commit comments