build: added ignore path for eslint - #16010
Closed
chrisbudy wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
.eslintignore is the default, so this change should be a no-op. I think the problem we saw at Code + Learn probably had to do with a problem in the .eslintignore itself? |
Sorry, something went wrong.
addaleax
approved these changes
Oct 7, 2017
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Doesn’t seem to hurt anybody, and if it helps someone, sure
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Can someone with a Windows machine (preferably @chrisbudy!) do this to confirm that this fixes anything or else confirm that it has no effect?
If the second step shows errors and the third step does not, then this PR should land. If any other combination occurs, then this PR should not land. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
BTW a better command is vcbuild noprojgen nobuild lint-js |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I can't repro. D:\code\node-github-desktop$ node tools/eslint/bin/eslint.js --rulesdir=tools/eslint-rules test\tmp\test.js D:\code\node-github-desktop\test\tmp\test.js 0:0 warning File ignored because of a matching ignore pattern. Use "--no-ignore" to override ✖ 1 problem (0 errors, 1 warning) I'd also be happy to hear from @chrisbudy that this positively solves the issue. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@chrisbudy maybe you have a global .eslintrc with a no-ignore rule? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@Trott I assumed it should default as well, but I was getting build errors on a tmp file (event though excluded in the .eslintignore file) at the code and learn, and adding the line I did stopped the build errors from happening. But I will test it again today. |
Sorry, something went wrong.
jasnell
approved these changes
Oct 9, 2017
Copy link
Copy Markdown
Member
|
@chrisbudy did you get the chance to test this again? |
Sorry, something went wrong.
Trott
requested changes
Oct 21, 2017
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Someone else tested this and unfortunately this doesn't solve the problem. See details here: #16278 (comment)
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I'm going to close this one but feel free to re-open or comment if you think this should stay open. The solution is likely a bug-fix in ESLint. Alternatively, we could add a common.refreshTmpDir() to the end of the test that creates the directory with multi-byte characters, but I'd prefer this be run up to ESLint instead, TBH. Will need some Windows folks willing to dig a bit, though. That's not me, unfortunately. |
Sorry, something went wrong.
refack
added a commit
to refack/node
that referenced
this pull request
Oct 26, 2017
Makes eslint exclude directories without enumerating their content PR-URL: nodejs#16372 Refs: nodejs#16010 Refs: nodejs#16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
refack
added a commit
to refack/node
that referenced
this pull request
Oct 26, 2017
`.tmp` prefix allows easier exclusion PR-URL: nodejs#16372 Refs: nodejs#16010 Refs: nodejs#16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
refack
added a commit
to refack/node
that referenced
this pull request
Oct 26, 2017
also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: nodejs#16372 Refs: nodejs#16010 Refs: nodejs#16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
Makes eslint exclude directories without enumerating their content PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
`.tmp` prefix allows easier exclusion PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
Makes eslint exclude directories without enumerating their content PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
`.tmp` prefix allows easier exclusion PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 30, 2017
also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 31, 2017
Makes eslint exclude directories without enumerating their content PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 31, 2017
`.tmp` prefix allows easier exclusion PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Oct 31, 2017
also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: #16372 Refs: #16010 Refs: #16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
Makes eslint exclude directories without enumerating their content PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
`.tmp` prefix allows easier exclusion PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
Makes eslint exclude directories without enumerating their content PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
`.tmp` prefix allows easier exclusion PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
Makes eslint exclude directories without enumerating their content PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
`.tmp` prefix allows easier exclusion PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: nodejs/node#16372 Refs: nodejs/node#16010 Refs: nodejs/node#16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
build