build: enforce order of dependency when building addons · nodejs/node@035a24e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 035a24e

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

MylesBorins

committed

build: enforce order of dependency when building addons

PR-URL: #17048 Fixes: #17043 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

1 parent 2f34d35 commit 035a24e
Copy full SHA for 035a24e

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Makefile

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -314,7 +314,7 @@ test/addons/.buildstamp: config.gypi \
314	314	# .buildstamp is out of date and need a rebuild.
315	315	# Just goes to show that recursive make really is harmful...
316	316	# TODO(bnoordhuis) Force rebuild after gyp update.
317		- build-addons: $(NODE_EXE) test/addons/.buildstamp
	317	+ build-addons: | $(NODE_EXE) test/addons/.buildstamp
318	318
319	319	ADDONS_NAPI_BINDING_GYPS := \
320	320	$(filter-out test/addons-napi/??_*/binding.gyp, \
@@ -353,7 +353,7 @@ test/addons-napi/.buildstamp: config.gypi \
353	353	# .buildstamp is out of date and need a rebuild.
354	354	# Just goes to show that recursive make really is harmful...
355	355	# TODO(bnoordhuis) Force rebuild after gyp or node-gyp update.
356		- build-addons-napi: $(NODE_EXE) test/addons-napi/.buildstamp
	356	+ build-addons-napi: | $(NODE_EXE) test/addons-napi/.buildstamp
357	357
358	358	clear-stalled:
359	359	# Clean up any leftover processes but don't error if found.

0 commit comments

Comments

0 (0)