FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: enforce order of dependency when building addons by joyeecheung · Pull Request #17048 · nodejs/node · GitHub

/ node Public

build: enforce order of dependency when building addons - #17048

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:order-node-exe
ConversationCommits (1)ChecksFiles changed
Closed

build: enforce order of dependency when building addons#17048
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:order-node-exe

Conversation

joyeecheung commented Nov 15, 2017

Copy link
Copy Markdown
Member

Fixes: #17043 (Hopefully)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

build

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 15, 2017

joyeecheung commented Nov 15, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/11456/

joyeecheung commented Nov 15, 2017

Copy link
Copy Markdown
Member Author

cc @refack

joyeecheung commented Nov 16, 2017

Copy link
Copy Markdown
Member Author

..hmm...still reproduce on smartos: https://ci.nodejs.org/job/node-test-commit-smartos/13154/nodes=smartos16-64/console

addaleax commented Nov 18, 2017

Copy link
Copy Markdown
Member

Landed in c5b8e16

addaleax closed this Nov 18, 2017
addaleax pushed a commit that referenced this pull request Nov 18, 2017
build: enforce order of dependency when building addons
c5b8e16 
PR-URL: #17048
Fixes: #17043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
joyeecheung mentioned this pull request Nov 19, 2017
Closed
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
build: enforce order of dependency when building addons
035a24e 
PR-URL: #17048
Fixes: #17043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
build: enforce order of dependency when building addons
f0fb1d4 
PR-URL: #17048
Fixes: #17043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins commented Dec 19, 2017

Copy link
Copy Markdown
Contributor

This does not land cleanly on v6.x should it be backported?

gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
build: enforce order of dependency when building addons
3036b36 
PR-URL: #17048
Fixes: #17043
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn mentioned this pull request Dec 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

build: Makefile dependency regression

6 participants

Back | FazBrowse Home | New Git URL