doc: cast GetInternalField() return type to v8::Value in addons.md · nodejs/node@0471c57 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 636
• Pull requests 762
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 0471c57

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

ruyadorno

committed

doc: cast GetInternalField() return type to v8::Value in addons.md

For the breaking change in https://chromium-review.googlesource.com/c/v8/v8/+/4707972 PR-URL: #49439 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent e341efe commit 0471c57
Copy full SHA for 0471c57

1 file changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • addons.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/addons.md‎

Copy file name to clipboardExpand all lines: doc/api/addons.md

+2-1Lines changed: 2 additions & 1 deletion

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -912,7 +912,8 @@ void MyObject::New(const FunctionCallbackInfo<Value>& args) {
912	912	const int argc = 1;
913	913	Local<Value> argv[argc] = { args[0] };
914	914	Local<Function> cons =
915		- args.Data().As<Object>()->GetInternalField(0).As<Function>();
	915	+ args.Data().As<Object>()->GetInternalField(0)
	916	+ .As<Value>().As<Function>();
916	917	Local<Object> result =
917	918	cons->NewInstance(context, argc, argv).ToLocalChecked();
918	919	args.GetReturnValue().Set(result);

0 commit comments

Comments

0 (0)