doc: cast GetInternalField() return type to v8::Value in addons.md - #49439
Merged
nodejs-github-bot merged 1 commit intoSep 7, 2023
Merged
doc: cast GetInternalField() return type to v8::Value in addons.md#49439nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
RaisinTen
approved these changes
Sep 4, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
tniessen
approved these changes
Sep 4, 2023
This was referenced Sep 5, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
20 tasks
aymen94
approved these changes
Sep 7, 2023
lpinca
approved these changes
Sep 7, 2023
26 tasks
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
For the breaking change in https://chromium-review.googlesource.com/c/v8/v8/+/4707972 PR-URL: #49439 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the breaking change in
https://chromium-review.googlesource.com/c/v8/v8/+/4834471