Commit 0493056
url: remove unused setURLConstructor function
PR-URL: #46485
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 8036583 commit 0493056
2 files changed
Lines changed: 0 additions & 33 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -93,7 +93,6 @@ const { | |||
| 93 | 93 | domainToUnicode: _domainToUnicode, | |
| 94 | 94 | encodeAuth, | |
| 95 | 95 | parse, | |
| 96 | - setURLConstructor, | ||
| 97 | 96 | URL_FLAGS_CANNOT_BE_BASE, | |
| 98 | 97 | URL_FLAGS_HAS_FRAGMENT, | |
| 99 | 98 | URL_FLAGS_HAS_HOST, | |
@@ -1573,29 +1572,6 @@ function toPathIfFileURL(fileURLOrPath) { | |||
| 1573 | 1572 | return fileURLToPath(fileURLOrPath); | |
| 1574 | 1573 | } | |
| 1575 | 1574 | ||
| 1576 | - function constructUrl(flags, protocol, username, password, | ||
| 1577 | - host, port, path, query, fragment) { | ||
| 1578 | - const ctx = new URLContext(); | ||
| 1579 | - ctx.flags = flags; | ||
| 1580 | - ctx.scheme = protocol; | ||
| 1581 | - ctx.username = (flags & URL_FLAGS_HAS_USERNAME) !== 0 ? username : ''; | ||
| 1582 | - ctx.password = (flags & URL_FLAGS_HAS_PASSWORD) !== 0 ? password : ''; | ||
| 1583 | - ctx.port = port; | ||
| 1584 | - ctx.path = (flags & URL_FLAGS_HAS_PATH) !== 0 ? path : []; | ||
| 1585 | - ctx.query = query; | ||
| 1586 | - ctx.fragment = fragment; | ||
| 1587 | - ctx.host = host; | ||
| 1588 | - | ||
| 1589 | - const url = ObjectCreate(URL.prototype); | ||
| 1590 | - url[context] = ctx; | ||
| 1591 | - const params = new URLSearchParams(); | ||
| 1592 | - url[searchParams] = params; | ||
| 1593 | - params[context] = url; | ||
| 1594 | - initSearchParams(params, query); | ||
| 1595 | - return url; | ||
| 1596 | - } | ||
| 1597 | - setURLConstructor(constructUrl); | ||
| 1598 | - | ||
| 1599 | 1575 | module.exports = { | |
| 1600 | 1576 | toUSVString, | |
| 1601 | 1577 | fileURLToPath, | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1824,13 +1824,6 @@ void DomainToUnicode(const FunctionCallbackInfo<Value>& args) { | |||
| 1824 | 1824 | String::NewFromUtf8(env->isolate(), out.c_str()).ToLocalChecked()); | |
| 1825 | 1825 | } | |
| 1826 | 1826 | ||
| 1827 | - void SetURLConstructor(const FunctionCallbackInfo<Value>& args) { | ||
| 1828 | - Environment* env = Environment::GetCurrent(args); | ||
| 1829 | - CHECK_EQ(args.Length(), 1); | ||
| 1830 | - CHECK(args[0]->IsFunction()); | ||
| 1831 | - env->set_url_constructor_function(args[0].As<Function>()); | ||
| 1832 | - } | ||
| 1833 | - | ||
| 1834 | 1827 | void Initialize(Local<Object> target, | |
| 1835 | 1828 | Local<Value> unused, | |
| 1836 | 1829 | Local<Context> context, | |
@@ -1839,7 +1832,6 @@ void Initialize(Local<Object> target, | |||
| 1839 | 1832 | SetMethodNoSideEffect(context, target, "encodeAuth", EncodeAuthSet); | |
| 1840 | 1833 | SetMethodNoSideEffect(context, target, "domainToASCII", DomainToASCII); | |
| 1841 | 1834 | SetMethodNoSideEffect(context, target, "domainToUnicode", DomainToUnicode); | |
| 1842 | - SetMethod(context, target, "setURLConstructor", SetURLConstructor); | ||
| 1843 | 1835 | ||
| 1844 | 1836 | #define XX(name, _) NODE_DEFINE_CONSTANT(target, name); | |
| 1845 | 1837 | FLAGS(XX) | |
@@ -1856,7 +1848,6 @@ void RegisterExternalReferences(ExternalReferenceRegistry* registry) { | |||
| 1856 | 1848 | registry->Register(EncodeAuthSet); | |
| 1857 | 1849 | registry->Register(DomainToASCII); | |
| 1858 | 1850 | registry->Register(DomainToUnicode); | |
| 1859 | - registry->Register(SetURLConstructor); | ||
| 1860 | 1851 | } | |
| 1861 | 1852 | ||
| 1862 | 1853 | std::string URL::ToFilePath() const { | |
0 commit comments