FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

url: remove unused `setURLConstructor` function by anonrig · Pull Request #46485 · nodejs/node · GitHub

/ node Public

url: remove unused setURLConstructor function - #46485

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:url-remove-unused
Feb 5, 2023
Merged

url: remove unused setURLConstructor function#46485
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:url-remove-unused

Conversation

anonrig commented Feb 3, 2023

Copy link
Copy Markdown
Member

Removing it before #46410 lands.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 3, 2023
anonrig added url Issues and PRs related to the legacy built-in url module. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 3, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 3, 2023

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

anonrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 3, 2023
anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 3, 2023
ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Feb 4, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 4, 2023

Copy link
Copy Markdown
Collaborator

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 5, 2023
nodejs-github-bot merged commit f013950 into nodejs:main Feb 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in f013950

MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
PR-URL: #46485
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Feb 19, 2023
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46485
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL