test: replace common.fixturesDir with fixtures.readSync() · nodejs/node@04af0fd · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 591
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 04af0fd

Browse filesBrowse the repository at this point in the historyBrowse files

AdriVanHoudt

authored and

MylesBorins

committed

test: replace common.fixturesDir with fixtures.readSync()

Replace common.fixturesDir with fixtures.readSync() in test-tls-getprotocol. PR-URL: #16802 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent d165d3f commit 04af0fd
Copy full SHA for 04af0fd

1 file changed

+6-3Lines changed: 6 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-tls-getprotocol.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-tls-getprotocol.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-tls-getprotocol.js

+6-3Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -3,9 +3,12 @@ const common = require('../common');
3	3	if (!common.hasCrypto)
4	4	common.skip('missing crypto');
5	5
	6	+ // This test ensures that `getProtocol` returns the right protocol
	7	+ // from a TLS connection
	8	+
6	9	const assert = require('assert');
7	10	const tls = require('tls');
8		- const fs = require('fs');
	11	+ const fixtures = require('../common/fixtures');
9	12
10	13	const clientConfigs = [
11	14	{ secureProtocol: 'TLSv1_method', version: 'TLSv1' },
@@ -14,8 +17,8 @@ const clientConfigs = [
14	17	];
15	18
16	19	const serverConfig = {
17		- key: fs.readFileSync(`${common.fixturesDir}/keys/agent2-key.pem`),
18		- cert: fs.readFileSync(`${common.fixturesDir}/keys/agent2-cert.pem`)
	20	+ key: fixtures.readSync('/keys/agent2-key.pem'),
	21	+ cert: fixtures.readSync('/keys/agent2-cert.pem')
19	22	};
20	23
21	24	const server = tls.createServer(serverConfig, common.mustCall(function() {

0 commit comments

Comments

0 (0)