FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace common.fixturesDir with fixtures.path() by AdriVanHoudt · Pull Request #16802 · nodejs/node · GitHub

/ node Public

test: replace common.fixturesDir with fixtures.path() - #16802

Closed
AdriVanHoudt wants to merge 2 commits into
nodejs:masterfrom
AdriVanHoudt:test-tls-protocol-fixtures
ConversationCommits (2)ChecksFiles changed
Closed

test: replace common.fixturesDir with fixtures.path()#16802
AdriVanHoudt wants to merge 2 commits into
nodejs:masterfrom
AdriVanHoudt:test-tls-protocol-fixtures

Conversation

AdriVanHoudt commented Nov 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
cjihrig approved these changes Nov 6, 2017
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with a suggestion.

Comment thread test/parallel/test-tls-getprotocol.js Outdated
const serverConfig = {
key: fs.readFileSync(`${common.fixturesDir}/keys/agent2-key.pem`),
cert: fs.readFileSync(`${common.fixturesDir}/keys/agent2-cert.pem`)
key: fs.readFileSync(fixtures.path('/keys/agent2-key.pem')),

cjihrig Nov 6, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you use fixtures.readSync() instead?

gireeshpunathil commented Nov 6, 2017

Copy link
Copy Markdown
Member

Thanks! some suggestions:

  1. There is a fixtures.readSync() function that you can use instead of fs.readFileSync() that directly reads from the fixtures.path.

  2. Once you do that you may eliminate the need for fs module. (else linter breaks)

  3. You may untick tests and/or benchmarks are included option in the description, as you did not include any new.

AdriVanHoudt commented Nov 6, 2017

Copy link
Copy Markdown
Contributor Author

Fixed! Thanks for the quick feedback 👍

mscdex added the tls Issues and PRs related to the tls subsystem. label Nov 6, 2017

Trott commented Nov 6, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11223/

Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 6, 2017
test: replace common.fixturesDir with fixtures.readSync()
e232cd8 
Replace common.fixturesDir with fixtures.readSync() in
test-tls-getprotocol.

PR-URL: nodejs#16802
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Trott commented Nov 6, 2017

Copy link
Copy Markdown
Member

Landed in e232cd8.

Thanks for the contribution! 🎉

Trott closed this Nov 6, 2017
AdriVanHoudt deleted the test-tls-protocol-fixtures branch November 6, 2017 17:49
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
test: replace common.fixturesDir with fixtures.readSync()
700c5e7 
Replace common.fixturesDir with fixtures.readSync() in
test-tls-getprotocol.

PR-URL: nodejs#16802
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
cjihrig mentioned this pull request Nov 6, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
test: replace common.fixturesDir with fixtures.readSync()
8de7515 
Replace common.fixturesDir with fixtures.readSync() in
test-tls-getprotocol.

PR-URL: #16802
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
test: replace common.fixturesDir with fixtures.readSync()
1e6845d 
Replace common.fixturesDir with fixtures.readSync() in
test-tls-getprotocol.

PR-URL: #16802
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins mentioned this pull request Nov 21, 2017
Merged
gibfahn mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
test: replace common.fixturesDir with fixtures.readSync()
95741c6 
Replace common.fixturesDir with fixtures.readSync() in
test-tls-getprotocol.

PR-URL: #16802
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
test: replace common.fixturesDir with fixtures.readSync()
04af0fd 
Replace common.fixturesDir with fixtures.readSync() in
test-tls-getprotocol.

PR-URL: #16802
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
cjihrig cjihrig approved these changes
gireeshpunathil gireeshpunathil approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL