Commit 05e72c9
util: move util.isSymbol to eol
PR-URL: #52744
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 832a77c commit 05e72c9
4 files changed
Lines changed: 5 additions & 44 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1304,6 +1304,9 @@ The `util.isString()` API has been removed. Please use | |||
| 1304 | 1304 | ||
| 1305 | 1305 | <!-- YAML | |
| 1306 | 1306 | changes: | |
| 1307 | + - version: REPLACEME | ||
| 1308 | + pr-url: https://github.com/nodejs/node/pull/52744 | ||
| 1309 | + description: End-of-Life deprecation. | ||
| 1307 | 1310 | - version: v22.0.0 | |
| 1308 | 1311 | pr-url: https://github.com/nodejs/node/pull/50488 | |
| 1309 | 1312 | description: Runtime deprecation. | |
@@ -1319,9 +1322,9 @@ changes: | |||
| 1319 | 1322 | description: Documentation-only deprecation. | |
| 1320 | 1323 | --> | |
| 1321 | 1324 | ||
| 1322 | - Type: Runtime | ||
| 1325 | + Type: End-of-Life | ||
| 1323 | 1326 | ||
| 1324 | - The [`util.isSymbol()`][] API is deprecated. Please use | ||
| 1327 | + The `util.isSymbol()` API has been removed. Please use | ||
| 1325 | 1328 | `typeof arg === 'symbol'` instead. | |
| 1326 | 1329 | ||
| 1327 | 1330 | ### DEP0058: `util.isUndefined()` | |
@@ -3799,7 +3802,6 @@ is deprecated to better align with recommendations per [NIST SP 800-38D][]. | |||
| 3799 | 3802 | [`util.isObject()`]: util.md#utilisobjectobject | |
| 3800 | 3803 | [`util.isPrimitive()`]: util.md#utilisprimitiveobject | |
| 3801 | 3804 | [`util.isRegExp()`]: util.md#utilisregexpobject | |
| 3802 | - [`util.isSymbol()`]: util.md#utilissymbolobject | ||
| 3803 | 3805 | [`util.isUndefined()`]: util.md#utilisundefinedobject | |
| 3804 | 3806 | [`util.log()`]: util.md#utillogstring | |
| 3805 | 3807 | [`util.promisify`]: util.md#utilpromisifyoriginal | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3140,31 +3140,6 @@ util.isRegExp({}); | |||
| 3140 | 3140 | // Returns: false | |
| 3141 | 3141 | ``` | |
| 3142 | 3142 | ||
| 3143 | - ### `util.isSymbol(object)` | ||
| 3144 | - | ||
| 3145 | - <!-- YAML | ||
| 3146 | - added: v0.11.5 | ||
| 3147 | - deprecated: v4.0.0 | ||
| 3148 | - --> | ||
| 3149 | - | ||
| 3150 | - > Stability: 0 - Deprecated: Use `typeof value === 'symbol'` instead. | ||
| 3151 | - | ||
| 3152 | - * `object` {any} | ||
| 3153 | - * Returns: {boolean} | ||
| 3154 | - | ||
| 3155 | - Returns `true` if the given `object` is a `Symbol`. Otherwise, returns `false`. | ||
| 3156 | - | ||
| 3157 | - ```js | ||
| 3158 | - const util = require('node:util'); | ||
| 3159 | - | ||
| 3160 | - util.isSymbol(5); | ||
| 3161 | - // Returns: false | ||
| 3162 | - util.isSymbol('foo'); | ||
| 3163 | - // Returns: false | ||
| 3164 | - util.isSymbol(Symbol('foo')); | ||
| 3165 | - // Returns: true | ||
| 3166 | - ``` | ||
| 3167 | - | ||
| 3168 | 3143 | ### `util.isUndefined(object)` | |
| 3169 | 3144 | ||
| 3170 | 3145 | <!-- YAML | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -90,15 +90,6 @@ function lazyAbortController() { | |||
| 90 | 90 | ||
| 91 | 91 | let internalDeepEqual; | |
| 92 | 92 | ||
| 93 | - /** | ||
| 94 | - * @deprecated since v4.0.0 | ||
| 95 | - * @param {any} arg | ||
| 96 | - * @returns {arg is symbol} | ||
| 97 | - */ | ||
| 98 | - function isSymbol(arg) { | ||
| 99 | - return typeof arg === 'symbol'; | ||
| 100 | - } | ||
| 101 | - | ||
| 102 | 93 | /** | |
| 103 | 94 | * @deprecated since v4.0.0 | |
| 104 | 95 | * @param {any} arg | |
@@ -381,9 +372,6 @@ module.exports = { | |||
| 381 | 372 | } | |
| 382 | 373 | return internalDeepEqual(a, b); | |
| 383 | 374 | }, | |
| 384 | - isSymbol: deprecate(isSymbol, | ||
| 385 | - 'The `util.isSymbol` API is deprecated. Please use `arg === "symbol"` instead.', | ||
| 386 | - 'DEP0057'), | ||
| 387 | 375 | isUndefined: deprecate(isUndefined, | |
| 388 | 376 | 'The `util.isUndefined` API is deprecated. Please use `arg === undefined` instead.', | |
| 389 | 377 | 'DEP0058'), | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -103,10 +103,6 @@ assert.strictEqual(util.isUndefined(), true); | |||
| 103 | 103 | assert.strictEqual(util.isUndefined(null), false); | |
| 104 | 104 | assert.strictEqual(util.isUndefined('string'), false); | |
| 105 | 105 | ||
| 106 | - assert.strictEqual(util.isSymbol(Symbol()), true); | ||
| 107 | - assert.strictEqual(util.isSymbol(), false); | ||
| 108 | - assert.strictEqual(util.isSymbol('string'), false); | ||
| 109 | - | ||
| 110 | 106 | assert.strictEqual(util.isFunction(() => {}), true); | |
| 111 | 107 | assert.strictEqual(util.isFunction(function() {}), true); | |
| 112 | 108 | assert.strictEqual(util.isFunction(), false); | |
0 commit comments